• For backward operations, dstpitch and srcpitch can
    be negative. This leads BLTUNSAFE macro into an
    overflow, and as a result, it avoids performing
    operations that are perfectly valid.
    
    The visible effect that led to that patch was the gnome-panel
    bar in Fedora10. Before this patch, you could see garbage
    clobbering a big portion of the bar.
    
    After this patch, this garbage is gone.
    
    Signed-off-by: Glauber Costa <glommer@redhat.com>
    
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5880 c046a42c-6fe2-441c-8c8c-71466251a162
    aliguori authored
     
    Browse Code »
  • qcow2 writes a cluster reference count on every cluster update.  This causes
    performance to crater when using anything but cache=writeback.  This is most
    noticeable when using savevm.  Right now, qcow2 isn't a reliable format
    regardless of the type of cache your using because metadata is not updated in
    the correct order.  Considering this, I think it's somewhat reasonable to use
    writeback caching by default with qcow2 files.
    
    It at least avoids the massive performance regression for users until we sort
    out the issues in qcow2. 
    
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5879 c046a42c-6fe2-441c-8c8c-71466251a162
    aliguori authored
     
    Browse Code »
  • qemu_get_clock() returns a structure containing the time the user wants
    to be set (either UTC time, a local time, or a given date). Use mktimegm()
    instead of mktime() to convert it into POSIX time without taking the host
    timezone into account.
    
    Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5878 c046a42c-6fe2-441c-8c8c-71466251a162
    aurel32 authored
     
    Browse Code »