• pci_register_device already mallocs the pci config space buffer filled
    with zeroes.
    
    Doing this again breaks some default config space writes like
    setting the subsystem vendor id and subsystem device id.
    
    Signed-off-by: Amit Shah <amit.shah@redhat.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    Amit Shah authored
     
    Browse Code »
  • When deleting an fd event there is a chance the object doesn't get
    deleted, but only ->deleted set positive and deleted somewhere later.
    
    Now, if we create a handler for the fd again before the actual
    deletion occurs, we end up writing data into an object that has
    ->deleted set, which is obviously wrong.
    
    I see two ways to fix this:
    
    1. Don't return ->deleted objects in the search
    2. Unset ->deleted in the search
    
    This patch implements 1. which feels safer to do. It fixes AIO issues
    I've seen with curl, as libcurl unsets fd event listeners pretty
    frequently.
    
    Signed-off-by: Alexander Graf <alex@csgraf.de>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    Alexander Graf authored
     
    Browse Code »
  • The linux loader is just an option rom like any other, just with
    some special requirements. Right now, our option rom resetting
    mechanism is not being applied to it. As a result, users using
    -kernel will not be able to successfully reboot their machines
    
    This patch fixes it by saving all the data we generated in
    the load_linux() function, to be used later by the option rom
    resetting mechanism.
    
    Signed-off-by: Glauber Costa <glommer@redhat.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    Glauber Costa authored
     
    Browse Code »
  • Currently, boot options are not preserved across a system reset.
    option roms can modify themselves, or can for instance restore the real
    int 0x19 vector after they tried to boot from it.
    
    To properly do that, we need a reset handler registered to deal with option
    roms. This patch is based on current version on qemu-kvm.git
    
    Signed-off-by: Glauber Costa <glommer@redhat.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    Glauber Costa authored
     
    Browse Code »
  • Need to drop QCOW_OFLAG_COPIED from a cluster pointer before freeing it.
    
    Add an explanation how thing meant to work.
    
    Signed-off-by: Gleb Natapov <gleb@redhat.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    Gleb Natapov authored
     
    Browse Code »
  • Signed-off-by: Gleb Natapov <gleb@redhat.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    Anthony Liguori authored
     
    Browse Code »
  • This is no user-flippable switch, and no arch makes use of disabling
    gdbstub support. So it's pointless to keep the related #ifdefs and
    configure hunks around - and risking breakages like 711c410fdd again.
    
    Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
    Jan Kiszka authored
     
    Browse Code »
  • Signed-off-by: Paul Brook <paul@codesourcery.com>
    Paul Brook authored
     
    Browse Code »
  • Signed-off-by: Paul Brook <paul@codesourcery.com>
    Paul Brook authored
     
    Browse Code »
  • Signed-off-by: Paul Brook <paul@codesourcery.com>
    Paul Brook authored
     
    Browse Code »

  • Sparc disassembler wants to check previous addresses for some stuff
    and this may actually cause faults to be generated to the guest if the
    address is close to page start, because of the function used for the
    memory access.
    
    Fix by changing ldub_code to cpu_memory_rw_debug, which doesn't trigger
    exceptions.
    
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
    Blue Swirl authored
     
    Browse Code »
  • We already print a directory prefix in non-verbose mode, so there's no
    point printing a messages when recursive make enters/leaves a directory.
    
    Signed-off-by: Paul Brook <paul@codesourcery.com>
    Paul Brook authored
     
    Browse Code »