• Refactor the monitor API and prepare it for decoupled terminals:
    term_print functions are renamed to monitor_* and all monitor services
    gain a new parameter (mon) that will once refer to the monitor instance
    the output is supposed to appear on. However, the argument remains
    unused for now. All monitor command callbacks are also extended by a mon
    parameter so that command handlers are able to pass an appropriate
    reference to monitor output services.
    
    For the case that monitor outputs so far happen without clearly
    identifiable context, the global variable cur_mon is introduced that
    shall once provide a pointer either to the current active monitor (while
    processing commands) or to the default one. On the mid or long term,
    those use case will be obsoleted so that this variable can be removed
    again.
    
    Due to the broad usage of the monitor interface, this patch mostly deals
    with converting users of the monitor API. A few of them are already
    extended to pass 'mon' from the command handler further down to internal
    functions that invoke monitor_printf.
    
    At this chance, monitor-related prototypes are moved from console.h to
    a new monitor.h. The same is done for the readline API.
    
    Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6711 c046a42c-6fe2-441c-8c8c-71466251a162
    aliguori authored
     
    Browse Code »
  • Currently, waiting for the user to type in some password blocks the
    whole VM because monitor_readline starts its own I/O loop. And this loop
    also screws up reading passwords from virtual console.
    
    Patch below fixes the shortcomings by using normal I/O processing also
    for waiting on a password. To keep to modal property for the monitor
    terminal, the command handler is temporarily replaced by a password
    handler and a callback infrastructure is established to process the
    result before switching back to command mode.
    
    Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6710 c046a42c-6fe2-441c-8c8c-71466251a162
    aliguori authored
     
    Browse Code »
  • Break readline_show_prompt out of readline_start so that (re-)printing
    the prompt can be controlled in a more fine-grained way.
    
    Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6709 c046a42c-6fe2-441c-8c8c-71466251a162
    aliguori authored
     
    Browse Code »
  • Reading the passwords for encrypted hard disks during early startup is
    broken (I guess for quiet a while now):
     - No monitor terminal is ready for input at this point
     - Forcing all mux'ed terminals into monitor mode can confuse other
       users of that channels
    
    To overcome these issues and to lay the ground for a clean decoupling of
    monitor terminals, this patch changes the initial password inquiry as
    follows:
     - Prevent autostart if there is some encrypted disk
     - Once the user tries to resume the VM, prompt for all missing
       passwords
     - Only resume if all passwords were accepted
    
    Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6707 c046a42c-6fe2-441c-8c8c-71466251a162
    aliguori authored
     
    Browse File »


  • this patch fixes a bug and improves the generic pixel conversion
    function in vnc.c.
    The bug is that when a new vnc client connects we need to reset the flag
    has_WMVi but currently we don't.
    The generic pixel conversion function is vnc_convert_pixel and currently
    is not very efficient since uses the division and multiplication
    operators.
    To make it more efficient I changed to use bit shift operators instead.
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6441 c046a42c-6fe2-441c-8c8c-71466251a162
    aliguori authored
     
    Browse Code »

  • [ The following text is in the "UTF-8" character set. ]
    
        [ Your display is set for the "koi8-r" character set.  ]
    
        [ Some characters may be displayed incorrectly. ]
    
    This patch fixes vga rendering when the guest endianness differs from
    the host endianness: in this case we can only share the buffer if the
    bpp is 32 and we must change the pixelformat accordingly.
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6413 c046a42c-6fe2-441c-8c8c-71466251a162
    malc authored
     
    Browse Code »

  • The DisplayState refactoring changed the machine init function to create a
    DisplayState for each VGA device instead of being passed an existing
    DisplayState.  This change is critical to enable multiple graphics device
    support.
    
    Unfortunately, the serial/parallel/console code is structured today to run
    before machine init to fill out the CharDriverState table which the machine
    init function uses to determine whether to create the required devices.
    
    Since a 'vc' is a type of CharDriverState, the CharDriverState code requires
    that a DisplayState exist before it runs creating a circular dependency.
    
    To fix this, this splits the creation of the initial CharDriverState from
    the initialization of the text console.  We can then in a second step associate
    a DisplayState with all TextConsoles.  This allows us to create the
    CharDriverState's first, machine init, then associate the TextConsoles with
    a DisplayState.
    
    This code screams for more cleanup.
    
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6352 c046a42c-6fe2-441c-8c8c-71466251a162
    aliguori authored
     
    Browse Code »
  • Patch 5/7
    
    This patch changes the graphical_console_init function to return an
    allocated DisplayState instead of a QEMUConsole.
    
    This patch contains just the graphical_console_init change and few other
    modifications mainly in console.c and vl.c.
    It was necessary to move the display frontends (e.g. sdl and vnc)
    initialization after machine->init in vl.c.
    
    This patch does *not* include any required changes to any device, these
    changes come with the following patches.
    
    Patch 6/7
    
    This patch changes the QEMUMachine init functions not to take a
    DisplayState as an argument because is not needed any more;
    
    In few places the graphic hardware initialization function was called
    only if DisplayState was not NULL, now they are always called.
    Apart from these cases, the rest are all mechanical substitutions.
    
    Patch 7/7
    
    This patch updates the graphic device code to use the new
    graphical_console_init function.
    
    As for the previous patch, in few places graphical_console_init was called
    only if DisplayState was not NULL, now it is always called.
    Apart from these cases, the rest are all mechanical substitutions.
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6344 c046a42c-6fe2-441c-8c8c-71466251a162
    aliguori authored
     
    Browse File »

  • This patch changes the DisplayState interface adding support for
    multiple frontends at the same time (sdl and vnc) and implements most
    of the benefit of the shared_buf patch without the added complexity.
    
    Currently DisplayState is managed by sdl (or vnc) and sdl (or vnc) is
    also responsible for allocating the data and setting the depth.
    Vga.c (or another backend) will do any necessary conversion.
    
    The idea is to change it so that is vga.c (or another backend) together
    with console.c that fully manage the DisplayState interface allocating
    data and setting the depth (either 16 or 32 bit, if the guest uses a
    different resolution or is in text mode, vga.c (or another backend) is
    in charge of doing the conversion seamlessly).
    
    The other idea is that DisplayState supports *multiple* frontends
    like sdl and vnc; each of them can register some callbacks to be called
    when a display event occurs.
    
    The interesting changes are:
    
    - the new structures and related functions in console.h and console.c
    
    in particular the following functions are very helpful to manage a
    DisplaySurface:
    
    qemu_create_displaysurface
    qemu_resize_displaysurface
    qemu_create_displaysurface_from
    qemu_free_displaysurface
    
    - console_select and qemu_console_resize in console.c
    this two functions manage multiple consoles on a single host display
    
    - moving code around in hw/vga.c
    as for the shared_buf patch this is necessary to be able to handle a dynamic
    DisplaySurface bpp
    
    - changes to vga_draw_graphic in hw/vga.c
    this is the place where the DisplaySurface buffer is shared with the
    videoram, when possible;
    
    
    Compared to the last version the only changes are:
    
    - do not remove support to dpy_copy in cirrus_vga
    - change the name of the displaysurface handling functions
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6336 c046a42c-6fe2-441c-8c8c-71466251a162
    aliguori authored
     
    Browse Code »
  • Do not handle bgr host displays in the backends.
    
    Right now a bgr flag exists so that sdl can set it, if the SDL_Surface
    is bgr.
    Afterwards the graphic device (e.g. vga.c) does the needed conversion.
    
    With this patch series is sdl that is responsible for rendering the format
    provided by the graphic device that must provide a DisplaySurface
    (ds->surface) in 16 or 32 bpp, rgb.
    Afterwards sdl creates a SDL_Surface from the given DisplaySurface and
    blits it into the main SDL_Surface using SDL_BlitSurface.
    
    Everything is handled by sdl transparently, because SDL_BlitSurface is
    perfectly capable of handling bgr displays by itself.
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
    
    
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6335 c046a42c-6fe2-441c-8c8c-71466251a162
    aliguori authored
     
    Browse Code »