gwj / at91sam9263 · Commits

Commit f4af02ed1bb688ffd8a944b878c6b57b508dbc03

Authored by aliguori
1 parent 234c9bcd

fix bug in block-qcow2.c:alloc_cluster_offset() (Shahar Frank) 

During the debugging of the new revision of the zero dedup patch I
stepped on the following bug in block-qcow2.c:alloc_cluster_offset(). I
am not sure what the exact damage this bug can do, but it may be very
nasty because you way not notice it effects until you will do some
snapshot operations or similar actions that rely on the reference
counting.

The bug is easy to spot using the new "check" verb I added to the
qemu-img in one of the previous patches. I will resend the qemu-img
patch again with the new version of the zero dedup.

Signed-off-by: Shahar Frank <shaharf@qumranet.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>



git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5313 c046a42c-6fe2-441c-8c8c-71466251a162
Inline Side-by-side
Showing 1 changed file with 1 additions and 1 deletions
block-qcow2.c
  View file @f4af02e
... ... @@ -917,7 +917,7 @@ static uint64_t alloc_cluster_offset(BlockDriverState *bs,
917 917 /* how many free clusters ? */
918 918  
919 919 while (i < nb_clusters) {
920   - cluster_offset = l2_table[l2_index + i];
  920 + cluster_offset = be64_to_cpu(l2_table[l2_index + i]);
921 921 if (cluster_offset != 0)
922 922 break;
923 923 i++;
... ...