gwj / at91sam9263 · Commits

Commit ee600be6a6379697d04673fd9ab10b66732b42e1

Authored by aurel32
1 parent 3003b8bb

ppc: fix crash in ppc system single step support 

There was a bogus case where two system debug ops get generated.  This
patch removes the broken system debug op. This was a left over after
making some changes to correctly generate debug ops on branch
operations inside gen_goto_tb();

The test case against this patch is to turn on single stepping with
timers, boot a linux kernel, set a breakpoint a do_fork and in gdb
execute "si 3000".  Then qemu-system-ppc will fault executing a debug
op, which should not have been executed.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5391 c046a42c-6fe2-441c-8c8c-71466251a162
Inline Side-by-side
Showing 1 changed file with 0 additions and 4 deletions
target-ppc/translate.c
  View file @ee600be
... ... @@ -3048,10 +3048,6 @@ static always_inline void gen_bcond (DisasContext *ctx, int type)
3048 3048 #endif
3049 3049 gen_op_btest_T1(ctx->nip);
3050 3050 no_test:
3051   - if (ctx->singlestep_enabled & GDBSTUB_SINGLE_STEP) {
3052   - gen_update_nip(ctx, ctx->nip);
3053   - gen_op_debug();
3054   - }
3055 3051 tcg_gen_exit_tb(0);
3056 3052 }
3057 3053 }
... ...