gwj / at91sam9263 · Commits

Commit 6f932f9172228f51afebad9b215d1874e887eb65

Authored by Arnaud Patard
Committed by Riku Voipio
1 parent 44607123

Return EOPNOTSUPP instead of ENOSYS for *xattr* syscalls 

In current code, we're sending ENOSYS to target when a syscall for the
xattrs is done. This makes applications like ls complain loudly about
that and breaks scripts parsing the output. Moreover, iirc, implemented
features of filesystems are are sending EOPNOTSUPP (I've not checked so
I may be a little bit wrong on that...).
So, I'm proposing to return -EOPNOTSUPP and make ls happy

Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
Inline Side-by-side
Showing 1 changed file with 2 additions and 1 deletions
linux-user/syscall.c
  View file @6f932f9
... ... @@ -6579,7 +6579,8 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
6579 6579 case TARGET_NR_removexattr:
6580 6580 case TARGET_NR_lremovexattr:
6581 6581 case TARGET_NR_fremovexattr:
6582   - goto unimplemented_nowarn;
  6582 + ret = -TARGET_EOPNOTSUPP;
  6583 + break;
6583 6584 #endif
6584 6585 #ifdef TARGET_NR_set_thread_area
6585 6586 case TARGET_NR_set_thread_area:
... ...