gwj / at91sam9263 · Commits

Commit 641636d19e3d8eeb8fac31e20641eaf33befd6e7

Authored by aliguori
1 parent 052ff921

qcow2 corruption: Fix alloc_cluster_link_l2 (Kevin Wolf) 

This patch fixes a qcow2 corruption bug introduced in SVN Rev 5861. L2 tables
are big endian, so entries must be converted before being passed to functions.

This bug is easy to trigger. The following script will create and destroy a
qcow2 image (the header is gone after three loop iterations):

    #!/bin/bash
    qemu-img create -f qcow2 test.qcow 1M
    for i in $(seq 1 10); do
    qemu-system-x86_64 -hda test.qcow -monitor stdio > /dev/null 2>&1 <<EOF
    savevm test-$i
    quit
    EOF
    done

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>


git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@7165 c046a42c-6fe2-441c-8c8c-71466251a162
Inline Side-by-side
Showing 1 changed file with 1 additions and 1 deletions
block-qcow2.c
  View file @641636d
... ... @@ -1007,7 +1007,7 @@ static int alloc_cluster_link_l2(BlockDriverState *bs, uint64_t cluster_offset,
1007 1007 goto err;
1008 1008  
1009 1009 for (i = 0; i < j; i++)
1010   - free_any_clusters(bs, old_cluster[i], 1);
  1010 + free_any_clusters(bs, be64_to_cpu(old_cluster[i]), 1);
1011 1011  
1012 1012 ret = 0;
1013 1013 err:
... ...