gwj / at91sam9263 · Commits

Commit 31c05501c76b917bef4ae477f093e27dc9ef1b3b

Authored by aliguori
1 parent 9a40611c

Missing cirrus_invalidate_region() in cirrus_do_copy() (Brian Kress) 

After doing a video to video copy, cirrus_do_copy() in cirrus_vga.c does a
conditional call to cirrus_invalidate_region() with an "if (!notify)" test.
However at this point the blt has already been done so it seems like this call
should be made unconditionally.  The patch below fixes some display update
problems when dragging windows under both X (fedora 10 guest) and a Windows XP
guest.

Signed-off-by: Brian Kress <kressb@moose.net>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>


git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6646 c046a42c-6fe2-441c-8c8c-71466251a162
Inline Side-by-side
Showing 1 changed file with 3 additions and 4 deletions
hw/cirrus_vga.c
  View file @31c0550
... ... @@ -781,10 +781,9 @@ static void cirrus_do_copy(CirrusVGAState *s, int dst, int src, int w, int h)
781 781 /* we don't have to notify the display that this portion has
782 782 changed since qemu_console_copy implies this */
783 783  
784   - if (!notify)
785   - cirrus_invalidate_region(s, s->cirrus_blt_dstaddr,
786   - s->cirrus_blt_dstpitch, s->cirrus_blt_width,
787   - s->cirrus_blt_height);
  784 + cirrus_invalidate_region(s, s->cirrus_blt_dstaddr,
  785 + s->cirrus_blt_dstpitch, s->cirrus_blt_width,
  786 + s->cirrus_blt_height);
788 787 }
789 788  
790 789 static int cirrus_bitblt_videotovideo_copy(CirrusVGAState * s)
... ...