gwj / at91sam9263 · Commits

Commit 0bb05eaff04d30609a98c0dae80bb5dba3e4e799

Authored by Glauber Costa
Committed by Anthony Liguori
1 parent 9f6839d4

fix segfault in setting migration speed 

Hi,

Whoever wrote this migrate_set_speed function is totally stupid.

Any failed or completed migration keeps its state to allow probing of
migration data, but has no associated file anymore. It is, thus,
possible to crash qemu by calling migrate_set_speed after a migration
is finished (or failed, or cancelled), but before another one starts.

This patch fixes it.

Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Inline Side-by-side
Showing 1 changed file with 3 additions and 1 deletions
savevm.c
  View file @0bb05ea
... ... @@ -556,7 +556,9 @@ int qemu_file_rate_limit(QEMUFile *f)
556 556  
557 557 size_t qemu_file_set_rate_limit(QEMUFile *f, size_t new_rate)
558 558 {
559   - if (f->set_rate_limit)
  559 + /* any failed or completed migration keeps its state to allow probing of
  560 + * migration data, but has no associated file anymore */
  561 + if (f && f->set_rate_limit)
560 562 return f->set_rate_limit(f->opaque, new_rate);
561 563  
562 564 return 0;
... ...